fix: error if sandbox process has already started #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
27
to
+30
| pub fn start(&mut self) -> anyhow::Result<()> { | ||
| if self.process.is_some() { | ||
| anyhow::bail!("Sandbox server already started"); | ||
| } |
There was a problem hiding this comment.
huh, what case were you hitting where start was being called multiple times? Still good to have this in here just in case though
There was a problem hiding this comment.
No, but reading the logic it seemed like it could be a hidden bug if logic changed external to this method
ChaoticTempest
approved these changes
May 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is intentional, opening PR more as a question of why this is the case that the process handle can get overwritten here