Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionOutcome does not include tokens_burnt #151

Closed
trezbouchez opened this issue Jun 19, 2022 · 2 comments
Closed

ExecutionOutcome does not include tokens_burnt #151

trezbouchez opened this issue Jun 19, 2022 · 2 comments

Comments

@trezbouchez
Copy link

trezbouchez commented Jun 19, 2022

As a contract developer I would like to be able to write robust end-to-end tests that include verification of the signer account balance to confirm the attached storage deposits are correctly handled (kept or refunded). To be able to correctly reconcile the resulting account balance I first need to be able to determine how much tokens were burnt to cover gas costs. Then the remaining balance difference is deposit-related and can be used to check the correctness of deposit handling. Unfortunately, it seems that the Rust version of the Workspaces does not report tokens_burnt. The Workspaces Rust version of the ExecutionOutcome struct is out of sync with core version (as declared in https://github.com/near/nearcore/blob/master/core/primitives/src/transaction.rs) where the latter includes some extra fields (tokens_burnt being one of them).

@ChaoticTempest
Copy link
Member

Whoops, don't know how this field slipped when I was adding the others, but thanks for bringing this to my attention! This PR resolves it: #168

@trezbouchez
Copy link
Author

Thanks, @ChaoticTempest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants