chore: tests for Lazy and moving out of unstable

[ruseinov]

work on #1199

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (5a4c595) to head (0fa782d).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
+ Coverage   80.01%   80.12%   +0.11%     
==========================================
  Files         102      106       +4     
  Lines       14598    14860     +262     
==========================================
+ Hits        11680    11907     +227     
- Misses       2918     2953      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[akorchyn]

Looks good. For some reason, I expected better performance. E.g. LookupSet which has ~1020 inserts compared to LazyOption with ~1200

[akorchyn]

@race-of-sloths score 8

[race-of-sloths]

@akorchyn Thank you for calling!

@ruseinov Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

• Tag @race-of-sloths inside your pull requests
• Wait for the maintainer to review and score your pull request
• Check out your position in the Leaderboard
• Keep weekly and monthly streaks to reach higher positions
• Boast your contributions with a dynamic picture of your Profile

For maintainers:

• Score pull requests that participate in the Race of Sloths and receive a reward
• Engage contributors with fair scoring and fast responses so they keep their streaks
• Promote the Race to the point where the Race starts promoting you
• Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

• For contributors
  • Include a PR: @race-of-sloths include to enter the Race with your PR
• For maintainers:
  • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
  • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
  • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
  • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

[ruseinov]

@akorchyn comments addressed!

[ruseinov]

Looks good. For some reason, I expected better performance. E.g. LookupSet which has ~1020 inserts compared to LazyOption with ~1200

Well, if it has to write on each insert to the storage (via flush) - it makes sense.

[akorchyn]

Small nit that you may skip. Awesome

[akorchyn]

I would name it insert_take to be consistent with insert_delete.

As I got confused initially that it is same as insert_delete_flush_once

[ruseinov]

will do

[ruseinov]

Small nit that you may skip. Awesome

I'll need to tune the iterations for the CI, then we are done.. It's a bit of a process, I'll poke you when green.