Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize LookupSet before stabilizing #659

Closed
austinabell opened this issue Dec 6, 2021 · 0 comments · Fixed by #664
Closed

Optimize LookupSet before stabilizing #659

austinabell opened this issue Dec 6, 2021 · 0 comments · Fixed by #664
Assignees

Comments

@austinabell
Copy link
Contributor

With #654, it uses LookupMap with () as the value type, which can lead to some unnecessary reads rather than just checking if a key exists. There also might be some unnecessary CPU cycles to use borsh to deserialize nothing (not sure if compiler would optimize away)

We want to make sure we do this before stabilizing, in case we need/want to change the storage format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants