Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ValidAccountId and make AccountId a newtype #446

Closed
austinabell opened this issue Jun 23, 2021 · 0 comments · Fixed by #448
Closed

Remove ValidAccountId and make AccountId a newtype #446

austinabell opened this issue Jun 23, 2021 · 0 comments · Fixed by #448

Comments

@austinabell
Copy link
Contributor

austinabell commented Jun 23, 2021 •
edited
Loading

The second wrapper type, ValidAccountId is only used for JSON serialization and validating the account ID is valid. This should all happen within one type, instead of AccountId being an alias to String
@austinabell austinabell mentioned this issue Jun 23, 2021
Open
10 tasks
@austinabell austinabell changed the title ValidAccountId -- just AccountId should always be valid Remove ValidAccountId and make AccountId a newtype Jun 23, 2021
@austinabell austinabell mentioned this issue Jun 24, 2021
Merged
@gagdiez gagdiez mentioned this issue Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(types): change account id to newtype and deprecate ValidAccountId near/near-sdk-rs
1 participant
@austinabell