Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-exported packages cleanup. #1112

Closed
ruseinov opened this issue Nov 16, 2023 · 3 comments · Fixed by #1163
Closed

Re-exported packages cleanup. #1112

ruseinov opened this issue Nov 16, 2023 · 3 comments · Fixed by #1163
Labels
docs enhancement good first issue Good for newcomers

Comments

@ruseinov
Copy link
Collaborator

Make sure we're using re-exported packages from near-sdk as opposed to adding those directly to Cargo.toml.

Some good examples of that include serde package in near-contract-standards.
@frol
Copy link
Collaborator

frol commented Nov 18, 2023

I asked @iho to work in this one

@PolyProgrammist PolyProgrammist mentioned this issue Mar 29, 2024
Merged
@PolyProgrammist
Copy link
Collaborator

@ruseinov @frol what are the other packages to re-export except this: #1163

@frol
Copy link
Collaborator

frol commented Mar 29, 2024

@PolyProgrammist I don't see any other places to be honest. Thanks for checking and fixing the remaining ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Cleanup re-exported packages PolyProgrammist/near-sdk-rs
3 participants
@frol @ruseinov @PolyProgrammist