Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor info_extractor to accumulate compilation errors #1006

Closed
itegulov opened this issue Jan 23, 2023 · 3 comments · Fixed by #1097
Closed

Refactor info_extractor to accumulate compilation errors #1006

itegulov opened this issue Jan 23, 2023 · 3 comments · Fixed by #1097
Labels
good first issue Good for newcomers

Comments

@itegulov
Copy link
Contributor

Currently ItemImplInfo, ItemTraitInfo (and potentially some others) return a compilation error as soon as they encounter a single method with a compilation error. Instead, they should accumulate such errors and combine them with syn::Error::combine. This would give a saner developer experience to the users whose contracts have multiple problems at once.

Originally pointed out in #980 (comment).
@itegulov itegulov added the good first issue Good for newcomers label Jan 23, 2023
@jaswinder6991
Copy link
Contributor

I want to work on this.

@uint
Copy link
Contributor

uint commented Jul 20, 2023

I want to work on this.

@jaswinder6991 Sorry for the wait. Feel free to start a PR for this and reach out if you have any questions!

@jaswinder6991 jaswinder6991 mentioned this issue Aug 8, 2023
Closed
@jaswinder6991
Copy link
Contributor

Hi @uint, opened this PR #1065 to address this issue.

@iho iho mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor info_extractor to accumulate compilation errors iho/near-sdk-rs
3 participants
@uint @itegulov @jaswinder6991