Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent error messages #369

Open
WuTao18 opened this issue Apr 8, 2023 · 3 comments
Open

Inconsistent error messages #369

WuTao18 opened this issue Apr 8, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@WuTao18
Copy link

WuTao18 commented Apr 8, 2023

In the store_action_receipts function located in near-indexer-for-explorer/database/src/adapters/receipts.rs, the error_message in await_retry_or_panic! is "Failed to store ReceiptActions in database", but in other functions, the error_message is "Something were stored in database" (1, 2, 3, 4).

@telezhnaya telezhnaya added the good first issue Good for newcomers label Apr 17, 2023
@telezhnaya
Copy link
Contributor

Hey @WuTao18! I agree, sometimes we have a mess in our log messages. The phrasing is also not the best.
If you have time, could you please help us with this?

@WuTao18
Copy link
Author

WuTao18 commented Apr 17, 2023

Hey @WuTao18! I agree, sometimes we have a mess in our log messages. The phrasing is also not the best. If you have time, could you please help us with this?

Sure, I'm glad to provide help.

@khorolets khorolets assigned WuTao18 and unassigned khorolets Apr 24, 2023
@khorolets
Copy link
Member

@WuTao18 I've assigned this issue to you since you're volunteering to help. It's just a mark for us that someone (in your happy case, you) is working on it.

Thank you for all your contributions! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants