Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of start options #331

Open
khorolets opened this issue Dec 14, 2022 · 0 comments
Open

Optimization of start options #331

khorolets opened this issue Dec 14, 2022 · 0 comments
Assignees
@morgsmccauley
Labels
low-priotiry

Comments

@khorolets
Copy link
Member

khorolets commented Dec 14, 2022 •
edited by exalate-issue-sync bot
Loading

Some pieces of code that are responsible for providing the start options (from-interruption, from-latest) are a bit suboptimal in terms of dependency injections.

refs:

During the #326 PR review, @telezhnaya suggested optimizing them by injecting the DB pool and jsonrpc-client accordingly, we decided to extract those suggestions into a separate issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgsmccauley morgsmccauley

Labels
low-priotiry
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khorolets @morgsmccauley