Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to make transactions and receipts adapters to sequential way #256

Open
khorolets opened this issue Feb 18, 2022 · 3 comments
Open
Assignees

Comments

@khorolets
Copy link
Member

khorolets commented Feb 18, 2022

Recent testnet load with 200+ transactions and 300+ receipts were lagging.

I really think this code causes the retry with a too heavy payload and we should try to avoid it

// We can process transactions and receipts in parallel
// because most of receipts depend on transactions from previous blocks,
// so we can save up some time here.
// In case of local receipts (they are stored in the same block with corresponding transaction),
// we hope retry logic will cover it fine
try_join!(transactions_future, receipts_future)?;

@khorolets
Copy link
Member Author

@telezhnaya what do you think?

/cc @frol

@frol
Copy link
Contributor

frol commented Feb 18, 2022

@khorolets Let's measure it on the specific block with and without concurrency and then make the final decision.

@frol
Copy link
Contributor

frol commented Apr 8, 2022

Just for the future investigation, the recent blocks that caused slowdowns on mainnet are around #61617473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants