Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize expired or failed proposal #59

Open
Tarnadas opened this issue Feb 22, 2024 · 0 comments
Open

Finalize expired or failed proposal #59

Tarnadas opened this issue Feb 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Tarnadas
Copy link

Hey,

when a proposal expired its status stays as "InProgress" as long as it doesn't get finalized. See e.g. this proposal:
https://near.org/astraplusplus.ndctools.near/widget/home?page=dao&tab=proposals&daoId=shitzu.sputnik-dao.near&proposalId=33

There can also be failed proposals. A FunctionCall proposal gets into failed status, when it has been approved but the tx failed, e.g. here:
https://near.org/astraplusplus.ndctools.near/widget/home?page=dao&tab=proposals&daoId=shitzu.sputnik-dao.near&proposalId=27

In order to finalize a proposal you can use act_proposal function and send Action::Finalize:
https://github.com/near-daos/sputnik-dao-contract/blob/main/sputnikdao2/src/proposals.rs#L585-L592

There are also edge cases explained:

  • if proposal expired during the failed state it will be marked as expired.
  • if the number of votes in the group has changed (new members has been added) the proposal can loose it's approved state.

Nevertheless no matter about the edge case, any expired or failed proposal should be able to be finalized, which should be really easy to add. There just needs to be a button to prompt the user to send the act_proposal tx.

@Tarnadas Tarnadas added the enhancement New feature or request label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant