Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean dependency updates #27

Closed
ylyangtw opened this issue Sep 3, 2024 · 4 comments
Closed

Clean dependency updates #27

ylyangtw opened this issue Sep 3, 2024 · 4 comments
Assignees

Comments

@ylyangtw
Copy link
Collaborator

ylyangtw commented Sep 3, 2024

There are several dependency updates from dependabot. Make changes accordingly and test them.
#13
#7
#6
#5

@ylyangtw
Copy link
Collaborator Author

ylyangtw commented Sep 3, 2024

@navarroc I have tested those 4 dependency updates, all work well together (tested created tool, executed the tool, checked the output). But I don't have the permission to review/assign/merge issues. Could you grant me the access?

@navarroc
Copy link
Collaborator

navarroc commented Sep 3, 2024

How did you test the hsql one? For that you would need to make hsql the DB instead of postgres by either building locally with maven, updating docker-compose to remove postgres so falls back to hsql or just running the pure docker image of datawolf. Did you do one of those?

On a separate note, let me add you as reviewer to the PR's and if you tested them, approve them and I can merge them.

@navarroc
Copy link
Collaborator

navarroc commented Sep 3, 2024

I found hsqldb is not compatible with java 8 by default (running mvn clean install fails because it runs the unit tess). By default, maven will download the java 11 version so I think we need to make our own PR for hsqldb - see this post here: https://stackoverflow.com/questions/74261785/how-to-get-hsqldb-2-7-1-jdk8-jar-from-maven-central-repository

Wherever we specify hsqldb, we need a the parameter mentioned in the slack post.

@ylyangtw
Copy link
Collaborator Author

ylyangtw commented Sep 4, 2024

How did you test the hsql one? For that you would need to make hsql the DB instead of postgres by either building locally with maven, updating docker-compose to remove postgres so falls back to hsql or just running the pure docker image of datawolf. Did you do one of those?

On a separate note, let me add you as reviewer to the PR's and if you tested them, approve them and I can merge them.

Oh no sorry, I only tested the functionalities without enabling hsql. I can test those too. Just curious -- when do we need to enable hsql?

@ylyangtw ylyangtw self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants