-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean dependency updates #27
Comments
@navarroc I have tested those 4 dependency updates, all work well together (tested created tool, executed the tool, checked the output). But I don't have the permission to review/assign/merge issues. Could you grant me the access? |
How did you test the hsql one? For that you would need to make hsql the DB instead of postgres by either building locally with maven, updating docker-compose to remove postgres so falls back to hsql or just running the pure docker image of datawolf. Did you do one of those? On a separate note, let me add you as reviewer to the PR's and if you tested them, approve them and I can merge them. |
I found hsqldb is not compatible with java 8 by default (running mvn clean install fails because it runs the unit tess). By default, maven will download the java 11 version so I think we need to make our own PR for hsqldb - see this post here: https://stackoverflow.com/questions/74261785/how-to-get-hsqldb-2-7-1-jdk8-jar-from-maven-central-repository Wherever we specify hsqldb, we need a the parameter mentioned in the slack post. |
Oh no sorry, I only tested the functionalities without enabling hsql. I can test those too. Just curious -- when do we need to enable hsql? |
There are several dependency updates from dependabot. Make changes accordingly and test them.
#13
#7
#6
#5
The text was updated successfully, but these errors were encountered: