Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage #389

Open
Kingmidas74 opened this issue Dec 22, 2021 · 5 comments
Open

Increase code coverage #389

Kingmidas74 opened this issue Dec 22, 2021 · 5 comments
Assignees
@smolchanovsky
Labels
Cost: M Good first issue Good for newcomers Priority: Low Type: Testing

Comments

@Kingmidas74
Copy link
Member

.. and hold stable at least 80%
@smolchanovsky smolchanovsky added Cost: L Priority: Low and removed Type: Enhancement New feature or request labels Dec 23, 2021
@smolchanovsky
Copy link
Member

Having excluded the forked parts of the code (they have already been tested), we found out the real percentage of test coverage - 74%. Just a little bit left! :)

@smolchanovsky
Copy link
Member

It seems that there are enough integration tests for the client, but there are none for the factory. We need to think about how to implement them.

Unit tests are also required for the following classes:

NClient

  • RestNClientBuilder
  • RestNClientFactoryBuilder

NClient.Standalone

  • ClientInterceptor

NClient.Common

  • Converters
  • ContentExtensions

NClient.Providers.Api.Rest

  • RestRequestBuilder

NClient.AspNetCore

  • NClientControllerFinder
  • VirtualControllerInterceptor
  • ControllerQualifier
  • VirtualControllerFeatureProvider
  • AddNClientControllersExtensions
  • ModelExtender

NClient.Providers.Mapping.LanguageExt

  • ResponseToEitherBuilder

@Kingmidas74
Copy link
Member Author

Go get 'em tiger!

@Kingmidas74 Kingmidas74 added the Good first issue Good for newcomers label Sep 3, 2022
@kolatcole
Copy link
Contributor

is anyone working on this?

@smolchanovsky
Copy link
Member

@kolatcole hi!
No, you can do it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smolchanovsky smolchanovsky

Labels
Cost: M Good first issue Good for newcomers Priority: Low Type: Testing
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kingmidas74 @smolchanovsky @kolatcole