Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project deletion via the Projects page shows erroneous error message #243

Closed
jvendetti opened this issue Jan 11, 2023 · 2 comments
Closed
Assignees
Labels

Comments

@jvendetti
Copy link
Member

I used the "Delete (admin only)" link to delete a spam project on the Projects page. BioPortal displayed an error message at the top of the page:

Screen Shot 2023-01-11 at 11 47 48 AM


Despite displaying the error message, the project was successfully deleted from the triplestore.

On a related note, there should probably be a confirmation message displayed when the delete link is clicked - something like "are you sure?" - before proceeding with the delete operation.

@jvendetti jvendetti added the bug label Jan 11, 2023
@jvendetti
Copy link
Member Author

OK - it turns out that the Rails 6.1 upgrade we originally deployed only in staging was accidentally deployed to production on January 5th. The erroneous error messages are a result of changes made to the ontologies_api_ruby_client in this pull request: ncbo/ontologies_api_ruby_client#13.

Syphax has submitted a new pull request that addresses the issues with error responses: #240. I'll work on evaluating and getting it deployed.

@jvendetti jvendetti self-assigned this Jan 26, 2023
@jvendetti
Copy link
Member Author

This issue is fixed now that #240 is merged / deployed.

Also - I made small repair so that a confirmation dialog is once again displayed for project delete operations (a71a1e4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant