Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure checker outputs say "you put X but we expected Y" wherever possible. #72

Open
agstephens opened this issue Dec 7, 2021 · 1 comment
Assignees

Comments

@agstephens
Copy link
Contributor

agstephens commented Dec 7, 2021

This could be easily improved:


--------------------------------------------------------------------------------
                         IOOS Compliance Checker Report
                   product_pm-concentration_land_checks:v2.0

--------------------------------------------------------------------------------
                               Corrective Actions
uea-fidas200E-1_ral_29001225_pm-concentration_v0.1.nc has 38 potential issues


                                 High Priority
--------------------------------------------------------------------------------
Global attribute: Conventions
* Required 'Conventions' global attribute value does not match regex 'CF\-1\.6,\ NCAS\-AMF\-2\.0\.0'.

Global attribute: platform
* Required 'platform' global attribute value is invalid.

Global attribute: platform_altitude
* Required 'platform_altitude' global attribute value does not match regex '-?\d+(\.\d+)? m'.
@agstephens
Copy link
Contributor Author

agstephens commented Jan 12, 2022

@gapintheclouds: let's do:

  • In a new branch: update the template messages in the compliance-check-lib register of check classes wherever we can make them more readable.
  • Create a PR on Github
  • Get review from GP/WG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants