Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like global attribute checks are duplicated #45

Open
agstephens opened this issue Sep 1, 2021 · 0 comments
Open

Looks like global attribute checks are duplicated #45

agstephens opened this issue Sep 1, 2021 · 0 comments
Assignees

Comments

@agstephens
Copy link
Contributor

See:

$ diff /vagrant-share/amf-compliance-checker-work-2021/check-data-2021-08-27/yaml_checks/v2.0/AMF_global_attrs.yml  /vagrant-share/amf-compliance-checker-work-2021/check-data-2021-08-27/yaml_checks/v2.0/AMF_product_common_global-attributes_land.yml
1c1
< suite_name: global_attrs_checks:2.0
---
> suite_name: product_common_global-attributes_land_checks:2.0
3c3
< description: Check 'global_attrs' in AMF files
---
> description: Check 'product common global-attributes land' in AMF files

They are the same, but both are referenced in the main check files (land, sea, air and trajectory):

$ grep attr yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_{land,sea,air,trajectory}.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_land.yml:- __INCLUDE__: AMF_global_attrs.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_land.yml:- __INCLUDE__: AMF_product_aerosol-backscatter-radial-winds_global-attributes.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_land.yml:- __INCLUDE__: AMF_product_common_global-attributes_land.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_sea.yml:- __INCLUDE__: AMF_global_attrs.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_sea.yml:- __INCLUDE__: AMF_product_aerosol-backscatter-radial-winds_global-attributes.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_sea.yml:- __INCLUDE__: AMF_product_common_global-attributes_sea.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_air.yml:- __INCLUDE__: AMF_global_attrs.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_air.yml:- __INCLUDE__: AMF_product_aerosol-backscatter-radial-winds_global-attributes.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_air.yml:- __INCLUDE__: AMF_product_common_global-attributes_air.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_trajectory.yml:- __INCLUDE__: AMF_global_attrs.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_trajectory.yml:- __INCLUDE__: AMF_product_aerosol-backscatter-radial-winds_global-att

We need to work out which one should be favoured.

@agstephens agstephens self-assigned this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant