Skip to content
This repository has been archived by the owner on Jul 16, 2022. It is now read-only.

Twitter bootstrap integration #138

Closed
ErazerBrecht opened this issue Sep 10, 2016 · 3 comments
Closed

Twitter bootstrap integration #138

ErazerBrecht opened this issue Sep 10, 2016 · 3 comments
Labels

Comments

@ErazerBrecht
Copy link

ErazerBrecht commented Sep 10, 2016

It seems this doesn't work anymore.

  • pickmeup doesn't get changed to: pickmeup-twitter-bootstrap well
  • The generated html isn't placed in the correct target (instead placed on the bottom of the HTML)
  • pmu-hidden is still on the container

I'm quite sure this problems are correlated. I tried to debug it to see where is goes wrong, but I didn't find it.

@nazar-pc
Copy link
Owner

I'm not actively using it, so it might be broken.
Will take a look.
What it basically does is following:

  • change root class, so that default styling doesn't apply
  • instantiate few TB-specific elements to compute their styles
  • get styles and generate new stylesheet with TB-specific styles
  • insert new stylesheet into document

@nazar-pc nazar-pc added the bug label Sep 10, 2016
@nazar-pc
Copy link
Owner

nazar-pc commented Oct 25, 2016

Could you take a look at 5bdc4d7? It should fix this issue, it is in master branch currently.

@ErazerBrecht
Copy link
Author

Will check it this weekend.

Thank you in advance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants