-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VENOM-184: Add support for voice and video calls #463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #463 +/- ##
=========================================
- Coverage 5.43% 4.74% -0.7%
=========================================
Files 81 90 +9
Lines 5723 6559 +836
=========================================
Hits 311 311
- Misses 5412 6248 +836
Continue to review full report at Codecov.
|
* Add Pipelines for Microphone (AudioIn), Speaker (AudioOut), Camera (VideoIn) and display (VideoOut) * Disable Pipewire device provider and src elements for now (they crash a lot) * Add a Call adapter to handle av calls and provide an additional layer on top of toxav * Migrate some instances of GLib.HashTable to Gee.HashMap * Update vapis from https://github.com/naxuroqa/vala-toxcore-c * Fix a bug in ConversationWindow that hindered you from sending messages on startup * Expand SettingsWidget, add options to select devices and some properties (unfinished) * Add a CallWidget which opens for calls (unfinished) * Tweak the layouts a bit * Remove deprecated calls to tox_self_get_connection_status * Add notifications for incoming calls * Move CallState to it's own file * Add an action to cancel/stop a call * Use actions to accept / decline / cancel calls in contact list and conversation widget * Visualize current call state in conversation widget * Remove optional gstreamer switcher (gstreamer-1.0 is mandatory now)
naxuroqa
added a commit
that referenced
this pull request
Dec 20, 2018
naxuroqa
added a commit
that referenced
this pull request
Jan 21, 2019
* Fixes wrong accelerator mods when trying to send a message for the first time in a conversation. Backport from #463
Hi. Any update on this? Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
Fixes #400
Fixes #464
ConversationWindow
that hindered you from sending messages on startupGLib.HashTable
toGee.HashMap
SettingsWidget
, add options to select devices and some properties (unfinished)CallWidget
which opens for calls (unfinished)tox_self_get_connection_status
TODO: (in other tickets)
TOXAV_ERR_SEND_FRAME_SYNC
errors when sending (research?)Visualize if the remote has muted himself or disabled video recording (E.g. show a placeholder instead)not possible with current toxcoreNot covered in this PR:
video_bit_rate
andaudio_bit_rate
changes from toxcore