VENOM-388: Fix user image getting reset when hitting apply #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapted the listener to load an identicon if there is no user avatar * Add an enum to differentiate between set/reset/no change in ViewModel * Set size of own images to 120x120px (default identicon size) * Removed `avatar` style class as it's not as pretty as it should be
Codecov Report
@@ Coverage Diff @@
## develop #391 +/- ##
===========================================
- Coverage 24.62% 24.58% -0.04%
===========================================
Files 101 101
Lines 5938 5946 +8
===========================================
Hits 1462 1462
- Misses 4476 4484 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewModel
avatarstyle class as it's not as pretty as it should befixes #388