Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VENOM-384: Implement tox identicons #385

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

naxuroqa
Copy link
Owner

@naxuroqa naxuroqa commented Jun 5, 2018

  • Add tox reference algorithm for identicons
  • Add unit tests
  • Add a round_corners function to round the corners of a Pixbuf
    with a radius of 10% of the width/height
  • Add usage of identicons for conference peers as well

fixes #384

* Add tox reference algorithm for identicons
* Add unit tests
* Add a `round_corners` function to round the corners of a Pixbuf
  with a radius of 10% of the width/height
* Add usage of identicons for conference peers as well
@codecov-io
Copy link

Codecov Report

Merging #385 into develop will increase coverage by 1.31%.
The diff coverage is 64.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #385      +/-   ##
===========================================
+ Coverage    23.53%   24.84%   +1.31%     
===========================================
  Files           99      101       +2     
  Lines         5733     5885     +152     
===========================================
+ Hits          1349     1462     +113     
- Misses        4384     4423      +39
Impacted Files Coverage Δ
src/tox/ConferenceMessage.vala 0% <0%> (ø) ⬆️
src/view/ConversationWindow.vala 0.54% <0%> (ø) ⬆️
src/tox/ToxAdapterFiletransferListener.vala 16.5% <0%> (ø) ⬆️
src/viewmodel/ContactListEntryViewModel.vala 0% <0%> (ø) ⬆️
src/viewmodel/ContactListViewModel.vala 0% <0%> (ø) ⬆️
src/tox/ToxAdapterFriendListener.vala 0% <0%> (ø) ⬆️
src/tox/FriendRequest.vala 0% <0%> (ø) ⬆️
src/viewmodel/MessageViewModel.vala 0% <0%> (ø) ⬆️
src/view/PeerEntry.vala 0% <0%> (ø) ⬆️
src/view/FriendRequestWidget.vala 0% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335d6d0...cc49953. Read the comment docs.

@naxuroqa naxuroqa merged commit cc49953 into develop Jun 5, 2018
@naxuroqa naxuroqa deleted the VENOM-384_implement_tox_identicons branch June 5, 2018 16:54
SkyzohKey pushed a commit to SkyzohKey/Venom that referenced this pull request Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tox identicons
2 participants