Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hacky workaround for model creator methods #333

Closed
naxuroqa opened this issue Apr 16, 2018 · 1 comment
Closed

Fix hacky workaround for model creator methods #333

naxuroqa opened this issue Apr 16, 2018 · 1 comment

Comments

@naxuroqa
Copy link
Owner

Currently ListBox.bind_model creates a dependency cycle to the containing class when a member creator method is used.

The current workaround is to unbind the model on unmap, which is not ideal.

The best solution is probably to put the needed dependencies unowned in a creator class

@naxuroqa
Copy link
Owner Author

Closed with #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant