Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VENOM-331: Fix friend address size not validated #332

Merged
merged 1 commit into from
Apr 15, 2018

Conversation

naxuroqa
Copy link
Owner

  • Throw an error if address is not of length TOX_ADDRESS_SIZE
  • Added a placeholder for the file transfer widget
  • Added a unique id for conferences to open the correct one
    when clicking on notifications

closes #331

* Throw an error if address is not of length TOX_ADDRESS_SIZE
* Added a placeholder for the file transfer widget
* Added a unique id for conferences to open the correct one
  when clicking on notifications
@codecov-io
Copy link

Codecov Report

Merging #332 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #332      +/-   ##
===========================================
- Coverage    38.78%   38.75%   -0.03%     
===========================================
  Files           49       49              
  Lines         2787     2789       +2     
===========================================
  Hits          1081     1081              
- Misses        1706     1708       +2
Impacted Files Coverage Δ
src/tox/ToxSession.vala 0.94% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95337ed...08c2f43. Read the comment docs.

@naxuroqa naxuroqa merged commit 08c2f43 into develop Apr 15, 2018
@naxuroqa naxuroqa deleted the VENOM-331_fix_friend_address_size_not_validated branch April 15, 2018 13:53
SkyzohKey pushed a commit to SkyzohKey/Venom that referenced this pull request Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix friend address size not validated
2 participants