Remove the unmount in development since it gives us console log spam, f…

…acebook/react#25675 (comment)
navikt · Dec 5, 2023 · 45b7547 · 45b7547
1 parent 1aacc24
commit 45b7547
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/shared-components/src/formio/components/base/FormioReactComponent.tsx b/packages/shared-components/src/formio/components/base/FormioReactComponent.tsx
@@ -17,9 +17,11 @@ class FormioReactComponent extends (ReactComponent as unknown as IReactComponent
   }
 
   detachReact(element) {
-    if (element && this.rootElement) {
+    // For now we prefer memory leak in development over spamming the console log...
+    // Wrapping in setTimeout causes problems when we do a redraw, so need to find a different solution.
+    // https://github.com/facebook/react/issues/25675#issuecomment-1518272581
+    if (element && this.rootElement && process.env.NODE_ENV !== 'development') {
       this.rootElement.unmount();
-      this.rootElement = undefined;
     }
   }