Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KotlinTypeDefaultArbitraryBuilder의 thenApply, acceptIf 파라미터 타입 경고 [v 1.1.6] #1133

Open
jurogrammer opened this issue Dec 26, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@jurogrammer
Copy link

Describe the bug

giveMeKotlinBuilder로 빌더를 생성 했음에도 thenApply, acceptIfbuilder.set() 사용시 deprecated 경고가 발생합니다.

제 생각엔 아래처럼 변경되어야 할 것으로 보입니다.
감사합니다!
as-is

  override fun thenApply(biConsumer: BiConsumer<T, ArbitraryBuilder<T>>): KotlinTypeDefaultArbitraryBuilder<T> =
        this.apply { delegate.thenApply(biConsumer) }

to-be

  override fun thenApply(biConsumer: BiConsumer<T, KotlinTypeDefaultArbitraryBuilder<T>>): KotlinTypeDefaultArbitraryBuilder<T> =
        this.apply { delegate.thenApply(biConsumer) }

Your environment

  • fixtureMonkey 1.1.6
  • kotlin 2.0.0

Steps to reproduce

스크린샷 2024-12-26 오후 5 55 08

Expected behaviour

deprecated 경고가 발생하지 않습니다.

Actual behaviour

deprecated 경고가 발생합니다.

@seongahjo
Copy link
Contributor

@jurogrammer 님 안녕하세요.

breaking change가 발생할 수 있어 다음 minor 버전에서 해결하고자 합니다.

해결되면 공유드리겠습니다. 감사합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants