Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shape): Fix non-grouped area/bar to be drawn from bottom of x Axis #1304

Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix(shape): Fix non-grouped area/bar to be drawn from bottom of x Axis #1304

merged 1 commit into from
Apr 3, 2020

Conversation

netil
Copy link
Member

@netil netil commented Apr 3, 2020

Issue

#1302

Details

Make area/bar path draw to not surpass x Axis position, if axis.y/y2.min option is set.

@netil
fix(shape): Fix non-grouped area/bar to be drawn from bottom of x Axis
5022e4c 
Make area/bar path draw to not surpass x Axis position, if axis.y/y2.min option is set.

Ref #1302
@netil netil added the bug label Apr 3, 2020
@netil netil self-assigned this Apr 3, 2020
@netil netil merged commit a47a829 into naver:master Apr 3, 2020
@netil netil deleted the shape#1302 branch April 3, 2020 07:45
@netil
Copy link
Member Author

netil commented Apr 3, 2020

🎉 This PR is included in version 1.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@netil netil added the released label Apr 3, 2020
netil added a commit that referenced this pull request Apr 3, 2020
@netil
skip: merge #1304
f660541
This was referenced Apr 10, 2020
Closed
Merged
netil added a commit that referenced this pull request Apr 10, 2020
@netil
fix(shape): Fix incorrect area/bar rendering
9f81fb2 
Fix side-effect caused by #1304, making to return y Axis base value based on the current y Axis scale value.
Make sure this to used only non-grouped data and for y Axis min is greater than 0.

Fix #1316
netil pushed a commit that referenced this pull request Apr 10, 2020
@semantic-release-bot
chore(release): 1.12.4 [skip ci]
c99dbc8 
## [1.12.4](1.12.3...1.12.4) (2020-04-10)

### Bug Fixes

* **shape:** Fix incorrect area/bar rendering ([9f81fb2](9f81fb2)), closes [#1304](#1304) [#1316](#1316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@netil netil

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@netil