Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chart.data has incorrect TS definitions #1248

Closed
ECrownofFire opened this issue Feb 21, 2020 · 2 comments
Closed

chart.data has incorrect TS definitions #1248

ECrownofFire opened this issue Feb 21, 2020 · 2 comments
Labels
chore released

Comments

@ECrownofFire
Copy link
Contributor

Description

The TS definition file for data.shown() has an incorrect type definition, it should be DataArray and not Data.

The same seems to be true of the function call as well.

Steps to check or reproduce

N/A
@netil netil added the chore label Feb 21, 2020
@netil netil mentioned this issue Feb 21, 2020
Merged
@netil netil closed this as completed in 3f9bfa5 Feb 21, 2020
@netil
Copy link
Member

netil commented Feb 21, 2020

Hi @ECrownofFire, thanks for the report. I also fixed other .data() APIs return type.

@netil
Copy link
Member

netil commented Mar 20, 2020

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@netil netil added the released label Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ECrownofFire @netil