Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bubble): expand bubble chart feature with plugin #1153

Closed
wants to merge 2 commits into from

Conversation

jm-chong
Copy link

@jm-chong jm-chong commented Dec 5, 2019

  • set bubble min/max radius, focus expand scale
  • implement new feature with plugin

Issue

none

Details

improve bubble chart feature

  • specify min / max radius
  • focus bubble when mouse over
  • override internal functions using plugin hook.
  • added demo page & test code

- set bubble min/max radius, focus expand scale
- implement new feature with plugin
@netil
Copy link
Member

netil commented Dec 6, 2019

Hi @jm-chong, great work!
Can you add documentation & type definition?

Take as ref. from other plugins:

@jm-chong
Copy link
Author

jm-chong commented Dec 6, 2019

Okay. I just added documentation and type definition.
If I missed any other things, please let me know.

@netil netil closed this in 49704e0 Dec 13, 2019
@netil
Copy link
Member

netil commented Dec 13, 2019

@jm-chong, just merged with some format & description updates.
Thanks again for the contribution!

netil pushed a commit that referenced this pull request Jan 16, 2020
# [1.12.0-next.1](1.11.1...1.12.0-next.1) (2020-01-16)

### Bug Fixes

* **arc:** Fix handling spaced data name ([4824a47](4824a47)), closes [#1168](#1168)
* **bar:** Bar's width resize according the zoom scale ([93184a2](93184a2)), closes [#1185](#1185)
* **core:** Fix onrendered firing time ([8b8665c](8b8665c)), closes [#1194](#1194)
* **gauge:** fixed wrong ratio calculation in 'gauge.type = "single"' ([9020246](9020246)), closes [#1205](#1205)
* **interaction:** Fix null data point interaction ([901da84](901da84)), closes [#1199](#1199)
* **line:** Fix nullish data rendering with regions ([d0ca937](d0ca937)), closes [#1172](#1172)
* **tooltip:** Revert on pointer-events css prop ([c74c27a](c74c27a)), closes [#1124](#1124) [#1155](#1155)

### Features

* **axis:** Intent to ship axis.y2.tick.rotate ([98992f3](98992f3)), closes [#1157](#1157) [#1158](#1158)
* **gauge:** more than one arc are possible for gauges ([7a80e02](7a80e02)), closes [#787](#787) [#1071](#1071) [#1163](#1163)
* **grid:** Intent to ship grid.focus.y ([13d65d1](13d65d1)), closes [#1154](#1154)
* **line:** Intent to ship bubble/line/scatter zerobased ([e45fb33](e45fb33)), closes [#1149](#1149) [#1150](#1150)
* **options:** Intent to ship Arc's expand.rate ([7d6f32f](7d6f32f)), closes [#1189](#1189)
* **plugin:** Intent to ship bubblecompare plugin ([49704e0](49704e0)), closes [#1153](#1153)
* **zoom:** Intent to ship zoom.reseteButton.onclick ([694cbcb](694cbcb)), closes [#1171](#1171)
netil pushed a commit that referenced this pull request Mar 20, 2020
# [1.12.0](1.11.1...1.12.0) (2020-03-20)

### Bug Fixes

* **arc:** Fix handling spaced data name ([4824a47](4824a47)), closes [#1168](#1168)
* **arc:** Fix overwriting gauge_max in MultiArcGauge with totalSum ([8b2c28e](8b2c28e)), closes [#1259](#1259) [#1260](#1260)
* **axis:** Correct y Axis tick padding ([145b960](145b960)), closes [#1251](#1251)
* **axis:** Fix adding duplicated <title> element ([8d45075](8d45075)), closes [#1271](#1271)
* **axis:** Fix axis label text position ([68b6b86](68b6b86)), closes [#1270](#1270)
* **axis:** Fix axis tick rotate translate ([1bc3f20](1bc3f20)), closes [#1250](#1250) [#1278](#1278)
* **axis:** Fix for multi axes data bound  ([3f8afba](3f8afba)), closes [/github.com//pull/1233#issuecomment-595675546](https://github.com//github.com/naver/billboard.js/pull/1233/issues/issuecomment-595675546)
* **axis:** Fix text being left behind if getBBox fails ([648aa41](648aa41)), closes [#1283](#1283) [#1284](#1284)
* **bar:** Bar's width resize according the zoom scale ([93184a2](93184a2)), closes [#1185](#1185)
* **callbacks:** Fix triggering in lazy rendering ([3e73fdf](3e73fdf)), closes [#1254](#1254)
* **core:** Fix onrendered firing time ([8b8665c](8b8665c)), closes [#1194](#1194)
* **gauge:** fixed wrong ratio calculation in 'gauge.type = "single"' ([9020246](9020246)), closes [#1205](#1205)
* **grid:** Fix focus grid to be maintained on resize  ([01ba388](01ba388)), closes [#1239](#1239)
* **interaction:** Fix null data point interaction ([901da84](901da84)), closes [#1199](#1199)
* **line:** Fix nullish data rendering with regions ([d0ca937](d0ca937)), closes [#1172](#1172)
* **radar:** Correct text label not showing ([9109fd5](9109fd5)), closes [#1241](#1241)
* **tooltip:** Auto pos adjustion for tooltip ([c54f731](c54f731)), closes [#1243](#1243) [#1239](#1239)
* **tooltip:** Fix tooltip position on overlapping data point ([8dba213](8dba213)), closes [#1267](#1267)
* **tooltip:** Revert on pointer-events css prop ([c74c27a](c74c27a)), closes [#1124](#1124) [#1155](#1155)
* **tooltip,interaction:** Correct tooltip behaves for touch environment ([7090fa9](7090fa9)), closes [#1253](#1253)

### Features

* **axis:** Autorotate x axis tick texts on type "category" and "timeseries" ([8c51d02](8c51d02)), closes [#1236](#1236) [#1250](#1250)
* **axis:** Clone y/y2-axis domain if no data is bound to one of them ([96ac5c7](96ac5c7)), closes [#1231](#1231) [#1233](#1233)
* **axis:** Intent to ship axis.x.min/max.fit ([1650955](1650955)), closes [#7](#7)
* **axis:** Intent to ship axis.y2.tick.rotate ([98992f3](98992f3)), closes [#1157](#1157) [#1158](#1158)
* **axis:** Intent to ship y Axes stepSize ([429c6ec](429c6ec)), closes [#1098](#1098)
* **gauge:** more than one arc are possible for gauges ([7a80e02](7a80e02)), closes [#787](#787) [#1071](#1071) [#1163](#1163)
* **grid:** Intent to ship grid.focus.y ([13d65d1](13d65d1)), closes [#1154](#1154)
* **line:** Intent to ship bubble/line/scatter zerobased ([e45fb33](e45fb33)), closes [#1149](#1149) [#1150](#1150)
* **options:** Intent to ship Arc's expand.rate ([7d6f32f](7d6f32f)), closes [#1189](#1189)
* **plugin:** Intent to ship bubblecompare plugin ([49704e0](49704e0)), closes [#1153](#1153)
* **tooltip:** Enhancement on callback options ([30a7718](30a7718)), closes [#1216](#1216)
* **tooltip:** Intent to ship tooltip.position.unit ([ac078a7](ac078a7)), closes [#1239](#1239)
* **zoom:** Intent to ship zoom.reseteButton.onclick ([694cbcb](694cbcb)), closes [#1171](#1171)
@netil
Copy link
Member

netil commented Mar 20, 2020

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@netil netil added the released label Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants