-
Notifications
You must be signed in to change notification settings - Fork 357
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(point): Check for node.childNodes existance for IE / Edge
Check if node.childNodes is defined before trying to access its length property and use node append when node doesn't have innerHTML prop. Fix #601 Close #602
- Loading branch information
1 parent
95db4c5
commit 59a5a05
Showing
2 changed files
with
26 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,3 +18,4 @@ Tony Quetano <[email protected]> | |
EunChan Park <[email protected]> | ||
Ina Ryu <[email protected]> | ||
Lennert Claeys <[email protected]> | ||
Bogdan Iuga <[email protected]> | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
netil
Member
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @netil , thanks for adding me to the authors list, but my opinion is I didn't really earned that inclusion yet. My initial changes didn't make it in the final version, and I had some days off so I didn't really helped you out with the rest of the PR.
I'll try and contribute whenever I feel like I can help, but in the meantime, my name up there doesn't really reflect reality