Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Make the backup_file optional when getting the config #95

Closed
joewesch opened this issue Jul 17, 2023 · 0 comments · Fixed by #96
Closed

FR: Make the backup_file optional when getting the config #95

joewesch opened this issue Jul 17, 2023 · 0 comments · Fixed by #96

Comments

@joewesch
Copy link
Contributor

Currently when running the default get_config we need to send in a file path to backup_file so it can save the config to a file:

make_folder(os.path.dirname(backup_file))
with open(backup_file, "w", encoding="utf8") as filehandler:
filehandler.write(running_config)

If we want to get the configuration but not save it we should be able to send in an empty string to disable this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant