Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve invoke unittest #5435

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Improve invoke unittest #5435

merged 9 commits into from
Mar 20, 2024

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Mar 18, 2024

Closes Nan

What's Changed

  • Added --pattern argument to invoke unittest.
  • Added --parallel-workers argument to invoke unittest.

@snaselj snaselj self-assigned this Mar 18, 2024
@snaselj snaselj marked this pull request as ready for review March 18, 2024 11:28
glennmatthews
glennmatthews reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything that should be documented in nautobot/docs/development/core/getting-started.md as a part of this PR?

Can you provide an example(s) of invoke unittest --pattern? Seems useful.

When would you want to use --parallel-workers instead of just --parallel?

@snaselj
Copy link
Contributor Author

snaselj commented Mar 18, 2024

Anything that should be documented in nautobot/docs/development/core/getting-started.md as a part of this PR?

Can you provide an example(s) of invoke unittest --pattern? Seems useful.

When would you want to use --parallel-workers instead of just --parallel?

Added relevant examples to getting started.

@snaselj snaselj requested a review from glennmatthews March 18, 2024 15:31
@snaselj snaselj mentioned this pull request Mar 20, 2024
Merged
glennmatthews
glennmatthews reviewed Mar 20, 2024
View reviewed changes
tasks.py
docker_command = f"run --workdir='/source/examples/example_app' --entrypoint '{command}' nautobot"
docker_command = f"run --rm --workdir='/source/examples/example_app' --entrypoint '{command}' nautobot"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Would be great to backport to develop as well, but not urgent.

@glennmatthews glennmatthews merged commit f76ff6c into next Mar 20, 2024
17 checks passed
@glennmatthews glennmatthews deleted the u/snaselj-improve-unittest branch March 20, 2024 16:12
snaselj added a commit that referenced this pull request Mar 21, 2024
@snaselj
feat: Backport tasks improvement to develop
4d188d8 
#5435
@snaselj snaselj mentioned this pull request Mar 21, 2024
Merged
glennmatthews pushed a commit that referenced this pull request Mar 21, 2024
@snaselj
feat: Backport tasks improvement to develop (#5462)
71c17f9 
#5435
edwardtheharris pushed a commit to edwardtheharris/nautobot that referenced this pull request Jul 15, 2024
@snaselj @edwardtheharris
feat: Backport tasks improvement to develop (nautobot#5462)
b1c05dc 
nautobot#5435
edwardtheharris pushed a commit to edwardtheharris/nautobot that referenced this pull request Jul 15, 2024
@snaselj @glennmatthews @edwardtheharris
Improve invoke unittest (nautobot#5435)
435941d 
---------

Co-authored-by: Glenn Matthews <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

@timizuoebideri1 timizuoebideri1 timizuoebideri1 approved these changes

Assignees

@snaselj snaselj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snaselj @glennmatthews @timizuoebideri1