Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for Device42 Test #456

Merged
merged 3 commits into from
May 14, 2024
Merged

Fix CI for Device42 Test #456

merged 3 commits into from
May 14, 2024

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented May 13, 2024

This PR is to fix the issue discussed in #455.

@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: device42 Issues/PRs for Device42 Integration labels May 13, 2024
@jdrew82 jdrew82 self-assigned this May 13, 2024
@jdrew82 jdrew82 requested a review from a team as a code owner May 13, 2024 21:10
@smk4664
Copy link
Contributor

smk4664 commented May 14, 2024

Should this not be changed to the correct string instead of removing? Nevermind, I see that Netmiko does not support F5/BigIP.

@jdrew82
Copy link
Contributor Author

jdrew82 commented May 14, 2024

Should this not be changed to the correct string instead of removing? Nevermind, I see that Netmiko does not support F5/BigIP.

My first attempt was to correct it but for some reason CI wasn't picking it up. Technically the other tests already validate functionality so I don't think this one in particular is really required.

@jdrew82 jdrew82 linked an issue May 14, 2024 that may be closed by this pull request
@jdrew82 jdrew82 merged commit 930d61e into develop May 14, 2024
16 checks passed
@jdrew82 jdrew82 deleted the patch-fix_455 branch May 14, 2024 16:07
@jdrew82 jdrew82 mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: device42 Issues/PRs for Device42 Integration type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failing on Wrong BIG-IP Netmiko Platform
3 participants