Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinning of drf-spectacular=0.26.3 incompatible with nautobot core #417

Closed
glennmatthews opened this issue Apr 9, 2024 · 0 comments · Fixed by #418
Closed

pinning of drf-spectacular=0.26.3 incompatible with nautobot core #417

glennmatthews opened this issue Apr 9, 2024 · 0 comments · Fixed by #418
Labels
type: bug Issues/PRs addressing a bug.

Comments

@glennmatthews
Copy link
Contributor

Environment

  • Python version:
  • Nautobot version: develop (2.2.1b1)
  • nautobot-ssot version: 2.5.0

Expected Behavior

Upstream CI to pass

Observed Behavior

https://github.com/nautobot/nautobot-app-ssot/actions/runs/8610217927/job/23595392845#step:5:410

#14 5.657 ERROR: Cannot install None, nautobot-ssot[all]==2.5.0 and nautobot==2.2.1b1 because these package versions have conflicting dependencies.
#14 5.658 
#14 5.658 The conflict is caused by:
#14 5.658     nautobot-ssot 2.5.0 depends on drf-spectacular==0.26.3
#14 5.658     nautobot-ssot[all] 2.5.0 depends on drf-spectacular==0.26.3
#14 5.658     nautobot 2.2.1b1 depends on drf-spectacular<0.27.0 and >=0.26.5
#14 5.658 

nautobot-ssot should not pin a specific version of a dependency that it receives from nautobot upstream. I notice several other version pins in pyproject.toml that may also be problematic, including:

packaging = ">=21.3, <24"
prometheus-client = "~0.17.1"

Steps to Reproduce

@glennmatthews glennmatthews added the type: bug Issues/PRs addressing a bug. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues/PRs addressing a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant