Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrations Dependent Upon Settings in Dev Environment #234

Closed
jdrew82 opened this issue Oct 4, 2023 · 2 comments · Fixed by #453
Closed

Integrations Dependent Upon Settings in Dev Environment #234

jdrew82 opened this issue Oct 4, 2023 · 2 comments · Fixed by #453
Assignees
@jdrew82
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: housekeeping

Comments

@jdrew82
Copy link
Contributor

jdrew82 commented Oct 4, 2023

Environment

  • Python version: 3.8
  • Nautobot version: 1.6.2+
  • nautobot-ssot version: 1.6.0

Expected Behavior

Expect running unit tests to run and pass regardless of the settings in the dev environment's nautobot_config.py file.

Observed Behavior

Currently running tests with any of the integrations enable setting set to False will cause some of the associated unit tests to fail.

Steps to Reproduce

  1. Setup Nautobot and SSoT.
  2. Disable some integrations like IPFabric.
  3. Run invoke unittest and look at failing tests.
@glennmatthews
Copy link
Contributor

Probably should be using @override_settings liberally in the tests. Good catch.

@jdrew82
Copy link
Contributor Author

jdrew82 commented Oct 4, 2023

Probably should be using @override_settings liberally in the tests. Good catch.

Yep!

@Kircheneer Kircheneer added status: accepted This issue has been accepted by the maintainers team for implementation type: housekeeping labels Oct 5, 2023
@jdrew82 jdrew82 self-assigned this May 7, 2024
@jdrew82 jdrew82 mentioned this issue May 7, 2024
Merged
@jdrew82 jdrew82 linked a pull request May 7, 2024 that will close this issue
Fix Integration Unit Tests #453
Merged
@jdrew82 jdrew82 mentioned this issue Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdrew82 jdrew82

Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Integration Unit Tests nautobot/nautobot-app-ssot
3 participants
@jdrew82 @glennmatthews @Kircheneer