Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial success between steps fails to run next step, even with Node id available #214

Closed
JohnStarich opened this issue Aug 20, 2024 · 0 comments · Fixed by #216
Closed
Labels
bug Something isn't working

Comments

@JohnStarich
Copy link
Member

JohnStarich commented Aug 20, 2024

Looks like now that we have support for partial successes (#212), there's some interesting edge cases in the query plan step evaluation. In this case, if we get a partial success we get back the Node id field but the dependent step doesn't run.

This is particularly problematic for array responses, where some nodes may fail but others may succeed. An error in one node shouldn't prevent the other nodes' fields from resolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant