Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commodity Instruments - Negative Prices #2330

Open
fabz1 opened this issue Feb 18, 2025 · 2 comments
Open

Commodity Instruments - Negative Prices #2330

fabz1 opened this issue Feb 18, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@fabz1
Copy link

fabz1 commented Feb 18, 2025

Hello,
I'm just evaluating your system for the use within commodity trading, where prices can be negative when running out of storage/flexibility (e.g. electricity, oil). I noticed that both the Instrument and Commodity class have a constraint on min_price >= 0.
Would it be possible to allow negative prices while still handle downstream tasks such as PnL or Margin calculations correctly?

@fabz1 fabz1 added the enhancement New feature or request label Feb 18, 2025
@stefansimik
Copy link
Contributor

Just adding additional related info from Discord:

  • Submitting orders with negative prices seems no issue
    • so also Commodity instrument should allow them,
    • or even better parent Instrument should not block negative prices by default (as Instrument is parent for all more specific instruments).

@cjdsellers
Copy link
Member

Hi @fabz1

Thanks for reaching out.

I think this makes sense and isn't too hard to shuffle the validation checks around to allow negative priced commodities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

3 participants