Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OrderModifyRejected event in Rust #1369

Closed
filipmacek opened this issue Nov 25, 2023 · 1 comment
Closed

Implement OrderModifyRejected event in Rust #1369

filipmacek opened this issue Nov 25, 2023 · 1 comment
Labels
rust Relating to the Rust core

Comments

@filipmacek
Copy link
Member

Feature Request

Order events OrderModifyRejected needs to be fully ported to rust https://github.com/nautechsystems/nautilus_trader/blob/develop/nautilus_core/model/src/events/order/modified_rejected.rs

  • write rust tests, pyo3 tests, add typings in nautilus_pyo3.pyi file

You can find inspiration in my PR for OrderDenied here https://github.com/nautechsystems/nautilus_trader/pull/1367/files

Asignee:
https://github.com/ayush-sb

@filipmacek filipmacek added the rust Relating to the Rust core label Nov 25, 2023
@cjdsellers cjdsellers changed the title Implement OrderModifyRejected order event in rust Implement OrderModifyRejected event in Rust Nov 30, 2023
@filipmacek
Copy link
Member Author

I am closing this, as I've taken this and implemented it here #1400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Relating to the Rust core
Projects
None yet
Development

No branches or pull requests

1 participant