Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page shadows checkbox in toolbar page view options is not working #3919

Open
5e-Cleric opened this issue Nov 27, 2024 · 1 comment
Open

Page shadows checkbox in toolbar page view options is not working #3919

5e-Cleric opened this issue Nov 27, 2024 · 1 comment
Labels
bug We say this works but it doesn't solution found A solution exists; just needs to be applied

Comments

@5e-Cleric
Copy link
Member

The page shadows checkbox currently has no effect on the actual shadow of the pages as of today. It's likely a last minute change to fix or clear some other function that broke it.

@5e-Cleric 5e-Cleric added the bug We say this works but it doesn't label Nov 27, 2024
@Gazook89
Copy link
Collaborator

Gazook89 commented Nov 28, 2024

I think it needs to be fixed right here, adding a dependency to the useMemo for displayOptions.pageShadows to the renderPages function:

renderedPages = useMemo(()=>renderPages(), [props.text]);

renderedPages = useMemo(()=>renderPages(), [displayOptions.pageShadows, props.text]);

@5e-Cleric 5e-Cleric added the solution found A solution exists; just needs to be applied label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We say this works but it doesn't solution found A solution exists; just needs to be applied
Projects
None yet
Development

No branches or pull requests

2 participants