Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Number of Subjects" Metric #312

Closed
tkeller-moxe opened this issue Oct 15, 2024 · 4 comments · Fixed by #314
Closed

Add "Number of Subjects" Metric #312

tkeller-moxe opened this issue Oct 15, 2024 · 4 comments · Fixed by #314
Assignees
Labels
proposal Enhancement idea or proposal

Comments

@tkeller-moxe
Copy link

tkeller-moxe commented Oct 15, 2024

What motivated this proposal?

We would like to track and create alerts on the number of subjects on a stream.
Something in our infrastructure has been having this not correctly correlate with the number of messages on a stream and it grows exponentially causing a memory leak. We would like to be able to monitor this for future regression and action.

What is the proposed change?

This Metric is available on the JSZ endpoint we would like this to be exported as a Prometheus metric.

Who benefits from this change?

NATs System Administrators and SMEs can leverage this datapoint to monitor system behavior from a single pane of glass instead of a CLI tool here or a webpage there.

What alternatives have you evaluated?

I can get this metric via the CLI or the web API myself. This is just the correct place to export it.

@tkeller-moxe tkeller-moxe added the proposal Enhancement idea or proposal label Oct 15, 2024
@Jarema
Copy link
Member

Jarema commented Oct 16, 2024

We can definately add this metric.

Are you interested in contributing it?

@tkeller-moxe
Copy link
Author

I was looking into contributing it but realized my knowledge of GO is substantially lacking. So I figured it made more sense to raise a request instead😅

@Jarema
Copy link
Member

Jarema commented Oct 17, 2024

No worries :).

We will work on that soon.

@Jarema Jarema self-assigned this Oct 17, 2024
@tkeller-moxe
Copy link
Author

Thank you! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Enhancement idea or proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants