Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] include account token position when describing exports #598

Merged

Conversation

brianmcgee
Copy link
Contributor

Addresses part of #597

When describing exports without any account token positions, the output looks like this:

+------------------------------------------------------------------------------------------------------------+
|                                                  Exports                                                   |
+--------------+-------------------+--------------+------------------------+--------+-------------+----------+
| Name         | Type              | Subject      | Account Token Position | Public | Revocations | Tracking |
+--------------+-------------------+--------------+------------------------+--------+-------------+----------+
| binary-cache | Service [Chunked] | nits.cache.> | -                      | No     | 0           | -        |
+--------------+-------------------+--------------+------------------------+--------+-------------+----------+

When describing exports that do contain account token positions, the output looks like this:

+----------------------------------------------------------------------------------------------------------------------------------+
|                                                             Exports                                                              |
+-----------------------------+------------------+----------------------+------------------------+--------+-------------+----------+
| Name                        | Type             | Subject              | Account Token Position | Public | Revocations | Tracking |
+-----------------------------+------------------+----------------------+------------------------+--------+-------------+----------+
| account-monitoring-streams  | Stream           | $SYS.ACCOUNT.*.>     | 3                      | Yes    | 0           | N/A      |
| account-monitoring-services | Service [Stream] | $SYS.REQ.ACCOUNT.*.* | 4                      | Yes    | 0           | -        |
+-----------------------------+------------------+----------------------+------------------------+--------+-------------+----------+

Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 0c208a6 into nats-io:main Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants