-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subject type #952
Add subject type #952
Conversation
We should validate subjects when publishing differently than when subscribing. When subscribing, we only validate for a valid subject. Not sure when the check should happen yet. |
Aye, this is just a Thinking about prior art a bit, think validating at the call site is fine. E.g think |
9af9ebf
to
86f0d81
Compare
86f0d81
to
6369297
Compare
6369297
to
928e924
Compare
Seeing a slight performance bump from main
Waiting on Xcode to finish updating so I can run instruments to check the heap profile on this. |
@caspervonb reminder - resolve the conflicts please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tiniest of tiny nits...
@@ -445,7 +447,7 @@ impl ConnectionHandler { | |||
length, | |||
} => { | |||
if let Some(subscription) = self.subscriptions.get_mut(&sid) { | |||
let message = Message { | |||
let message: Message = Message { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let message: Message = Message { | |
let message = Message { |
This change might not be needed (most probably added by me, during rebase...).
Just wanted to through in a reminder that #596 exists 😄. So the only thing I really would like to see when a
All in all, a nice implementation 👍 I really like the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds a bytes based immutable string type for subjects.
Goal is to have the same interface as String, minus the mutability.
Bytes
directly where applicableCloses #950