Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SubscribeError public #899

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Make SubscribeError public #899

merged 2 commits into from
Mar 26, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Mar 26, 2023

Closes #897

@Jarema
Make SubscribeError public
3d16d58 
Signed-off-by: Tomasz Pietrek <[email protected]>
@Jarema Jarema requested a review from caspervonb March 26, 2023 12:03
@Jarema Jarema merged commit 22a9cc1 into main Mar 26, 2023
@Jarema Jarema deleted the jarema-make-subscribe-error-public branch March 26, 2023 13:35
@martsokha
Copy link

was it reverted? using async-nats = { version = "0.29.0" }, SubscribeError seems to be private

@Jarema Jarema mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subscribe returns private SubscribeError
3 participants
@Jarema @martsokha @caspervonb