Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing eror cases in Stream #542

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Handle missing eror cases in Stream #542

merged 2 commits into from
Jul 4, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jun 30, 2022

Signed-off-by: Tomasz Pietrek [email protected]

@Jarema
Copy link
Member Author

Jarema commented Jul 1, 2022

this fails because of new clippy error. fixed in #543

@Jarema Jarema requested a review from caspervonb July 1, 2022 13:19
@caspervonb caspervonb force-pushed the jarema/fix-pull-errors branch from 090ed95 to d55d600 Compare July 4, 2022 06:42
@caspervonb
Copy link
Collaborator

caspervonb commented Jul 4, 2022

Typo in both commit messages 😅 (also, they're status code cases?).
Lgtm once you've fixed up the commit messages.

@Jarema Jarema force-pushed the jarema/fix-pull-errors branch from d55d600 to e907b90 Compare July 4, 2022 08:04
@Jarema
Copy link
Member Author

Jarema commented Jul 4, 2022

@caspervonb fixed 🦀

Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarema Jarema merged commit 06de577 into main Jul 4, 2022
@Jarema Jarema deleted the jarema/fix-pull-errors branch July 4, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants