Add compression option to kv #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <[email protected]>
|
relevant issue: nats-io/nats-architecture-and-design#253 |
neilalexander
approved these changes
Oct 27, 2023
piotrpio
reviewed
Oct 28, 2023
There was a problem hiding this comment.
Backtracking a bit - ADR specified compression for KV as a boolean flag, rather than allowing to pick up a specific compression algorithm - https://github.com/nats-io/nats-architecture-and-design/pull/252/files
We need to discuss and align this setting across all clients
|
For KV where the purpose is minimal API surface area and minimal choices - and maximal chance of having alternative backends a Boolean is best. We should make the right choice for users and not surface extra options where those will just complicate matters. That means today it’s s2 or nothing |
|
I need to think about it for a while. But I think agree. Will follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek [email protected]