Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream::Config duplicate_window should be a Duration #1001

Closed
paolobarbolini opened this issue Jun 22, 2023 · 1 comment · Fixed by #1023
Closed

stream::Config duplicate_window should be a Duration #1001

paolobarbolini opened this issue Jun 22, 2023 · 1 comment · Fixed by #1023
Assignees
@Jarema
Labels
enhancement Enhancement to existing functionality

Comments

@paolobarbolini
Copy link
Contributor

Use case

Use a better type for declaring the duplicate_window

Proposed change

Make duplicate_window into a Duration

nats.rs/async-nats/src/jetstream/stream.rs

Line 1026 in 76789df

pub duplicate_window: i64,

Who benefits from the change(s)?

Users of the library

Alternative Approaches

Leave it as is but document the unit of measure
@paolobarbolini paolobarbolini added enhancement Enhancement to existing functionality needs triage labels Jun 22, 2023
@Jarema
Copy link
Member

Jarema commented Jun 22, 2023

Thanks @paolobarbolini! Good catch :).

@Jarema Jarema self-assigned this Jun 22, 2023
@n1ghtmare n1ghtmare mentioned this issue Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jarema Jarema

Labels
enhancement Enhancement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change stream::Config::duplicate_window to Duration n1ghtmare/nats.rs
3 participants
@caspervonb @paolobarbolini @Jarema