Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Fix syntax errors. #507

Merged
merged 1 commit into from
Aug 20, 2019
Merged

README: Fix syntax errors. #507

merged 1 commit into from
Aug 20, 2019

Conversation

thylong
Copy link
Contributor

@thylong thylong commented Aug 20, 2019

This PR proposes 2 small fixes on the README examples.

The current examples focuses on the concept introduction rather than compilable snippets.
To keep the current philosophy of the examples without having as a newcomer to dig into the examples/ directory straight away, these fixes help to reduce the overhead of copy/pasting/editing prior the first execution.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.435% when pulling e3d0990 on thylong:master into 33793de on nats-io:master.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks.

@derekcollison derekcollison merged commit 61959f4 into nats-io:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants