[IMPROVED] Server pool is updated based on server notifications #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server pool was only growing when new servers were discovered. Now, the client library updates its server pool based on server's INFO protocols (true for server 1.0.6+). The DiscoveredServersCB is still invoked only when new servers are added (as in never seen as opposed to added back after leaving the cluster). The code should work ok with older servers but will take advantage of changes in the server (nats-io/nats-server#626)
|
Note that one test checks that server version will be 1.0.6+ since test expects INFO content to be updated when servers leave the cluster, which does not happen with current version (1.0.4) of the server. |
|
LGTM |
kozlovic
added a commit
that referenced
this pull request
Mar 16, 2018
Continuation of #344. We don't want to remove discovered servers from the pool if we get an INFO with empty array. The new servers will send arrays with at least their own URL, but older servers or in some situations, the array could be empty (omitted) and we should not treat this as if there were no server at all in the cluster.
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server pool was only growing when new servers were discovered.
Now, the client library updates its server pool based on server's
INFO protocols (true for server 1.0.6+).
The DiscoveredServersCB is still invoked only when new servers
are added (as in never seen as opposed to added back after leaving
the cluster).
The code should work ok with older servers but will take advantage
of changes in the server (nats-io/nats-server#626)