Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed nats RootCAs redundant type conversion of rootPEM and fixed typo #324

Merged
merged 3 commits into from
Oct 20, 2017

Conversation

sknji
Copy link

@sknji sknji commented Oct 20, 2017

Removed nats RootCAs redundant type conversion of rootPEM. ioutil.ReadFile returns []byte, and err. There is no need to typecast rootPEM to []byte since it's already in bytes if there is no error.

Fixed typo in nats setupServerPool method description

Fixed nats connect comment word spacing.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.512% when pulling 81898b2 on marmotini:fix-typo into 4b47946 on nats-io:master.

@sknji sknji changed the title Fixed typo in nats setupServerPool method description. Removed nats RootCAs redundant type conversion of rootPEM and fixed typo Oct 20, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.512% when pulling f1bbc81 on marmotini:fix-typo into 4b47946 on nats-io:master.

Copy link
Contributor

@tylertreat tylertreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. lgtm

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 71bdf9c into nats-io:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants