Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new-style request leak #299

Merged
merged 4 commits into from
Jun 7, 2017
Merged

Fix new-style request leak #299

merged 4 commits into from
Jun 7, 2017

Commits on Jun 2, 2017

  1. Fix new-style request leak 

    The new request style was leaking channels in the respMap when requests
timed out. Now we remove them from the map when the request times out.

This also simplifies the respMux setup and prevents multiple resp
subscriptions from being created on the server.
    Tyler Treat committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    b60db10 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2017

  1. Address CR feedback and missed RequestWithContext

    Tyler Treat committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    c83b112 View commit details
    Browse the repository at this point in the history

  2. Cleanup channel map on RequestWithContext timeout

    Tyler Treat committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    fc8a243 View commit details
    Browse the repository at this point in the history

  3. Reduce locking around respSub

    Tyler Treat committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    301a5b1 View commit details
    Browse the repository at this point in the history