[ADDED] KeyValue: RePublish option in KeyValueConfiguration #1031
Conversation
Ability to create a KV with the re-publish feature. Signed-off-by: Ivan Kozlovic <[email protected]>
|
@bruth Wanted to add you as a reviewer, but for some reason I could not find you in the list. Maybe you need to be added into some GH lists. |
|
@codegangsta @derekcollison I think that the stream cannot be updated with RePublish, meaning it may not reject the update per-se (as it did with pull consumer MaxWaiting), but it is actually not updating the stream and therefore the feature is not enabled. For this PR maybe I keep it that it would fail if the stream is originally not created with RePublish (don't try to auto-update). Will then need to add a test in server to demonstrate the issue, or @derekcollison if you think that it should be supported or should work, I may have done something wrong in my client test... |
|
I am ok with rejecting, just need to formalize the rejection in the server code. If need be we can add update support at a later time. |
|
Ok, so will update this PR with test that verifies that 2nd create with republish fails as expected, then will go to server to add test that ensure that we reject update properly (started to work on a test and update is not rejected, but republish update is clearly not applied). |
|
Perfect thanks. |
This cannot be updated in the server at the moment, so if user calls CreateKeyValue() with a config that does not have RePublish and then call again on the same bucket with RePublish set, the user will get an error. Added a test that shows that this is the case. Signed-off-by: Ivan Kozlovic <[email protected]>
Ability to create a KV with the re-publish feature.
Signed-off-by: Ivan Kozlovic [email protected]