Added UpdatesOnly to kwWatchOptions #818
Merged
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
==========================================
+ Coverage 68.71% 70.47% +1.76%
==========================================
Files 39 47 +8
Lines 15207 15373 +166
Branches 3143 3181 +38
==========================================
+ Hits 10449 10834 +385
+ Misses 1700 1465 -235
- Partials 3058 3074 +16 ☔ View full report in Codecov by Sentry. |
kozlovic
approved these changes
Nov 13, 2024
| @@ -32121,6 +32121,16 @@ void test_KeyValueWatch(void) | |||
| natsThread_Join(t); | |||
| natsThread_Destroy(t); | |||
| kvWatcher_Destroy(w); | |||
|
|
|||
There was a problem hiding this comment.
nit: As best practice, I would set w to NULL since you are going to recreate below. But since if it is fails to be created we fail (testCond() would exit), then there is no risk of "double free" when calling kvWatcher_Destroy() again...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested on Slack, https://natsio.slack.com/archives/C01AWP40KGF/p1729791332242309